Makes streaming Subscription iterable #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
==========================================
- Coverage 86.63% 86.03% -0.60%
==========================================
Files 84 87 +3
Lines 4473 4783 +310
==========================================
+ Hits 3875 4115 +240
- Misses 598 668 +70 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Should close #730 |
berndverst
approved these changes
Nov 11, 2024
elena-kolevska
added a commit
to elena-kolevska/python-sdk
that referenced
this pull request
Mar 6, 2025
* Make Streaming Subscription iterable Signed-off-by: Elena Kolevska <[email protected]> * Adds iter for async client Signed-off-by: Elena Kolevska <[email protected]> * linter and updates docs Signed-off-by: Elena Kolevska <[email protected]> --------- Signed-off-by: Elena Kolevska <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As agreed in the original bidirectional streaming PR, I'm making the sync and async Subscription objects iterable.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: